Skip to content

add Automatic-Module-Name to manifest #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SethTisue
Copy link
Member

No description provided.

@SethTisue
Copy link
Member Author

sanity check: after this change, running sbt publishLocal and inspecting the MANIFEST.MF in the resulting jar shows:

Manifest-Version: 1.0                                                                                                   
Automatic-Module-Name: scala.util.parsing
...

@SethTisue SethTisue force-pushed the automatic-module-name branch from 16f1b89 to 5e90401 Compare May 13, 2021 21:12
@SethTisue
Copy link
Member Author

the sbt-scala-module bump is getting us a newer MiMa which is running afoul of lightbend-labs/mima#630

@SethTisue SethTisue marked this pull request as draft May 13, 2021 23:08
@Philippus
Copy link
Member

This change was cherry-picked into #392.

@Philippus Philippus closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants